Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating read.me and docs for template #5

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

stefanfrench
Copy link
Contributor

What's changing

Modified the template read.me to reflect latest approach. Added some generic pages to the Docs.

Relates to 31

How to test it

Check docs run mkdocs serve

Additional notes for reviewers

  • Review the content and structure of the read.me.
  • Review the generic content in the Docs

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and under /docs)

@stefanfrench stefanfrench self-assigned this Dec 10, 2024
@@ -1,3 +1 @@
# API Reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is obvious already so it is not needed but I originally left this to showcase the syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i left it, it caused an error when I ran mkdocs serve:
ERROR - Error reading page 'api.md': ERROR - Could not collect 'blueprint.hello'

i'll try re-add the example as a string to avoid the error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR - Error reading page 'api.md': ERROR - Could not collect 'blueprint.hello'

Right, I think it might be because the project itself was not installed.
You need to:

pip install -e .

From the root so mkdocs can import the blueprint module.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes needed in order to make the workflows work on this repo, I will open a PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daavoo - okay do you want me to hold-off merging this? or can i go ahead and then you will do another PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ok to merge this, I will open a different PR

@@ -1,3 +1 @@
# API Reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ok to merge this, I will open a different PR

@daavoo daavoo merged commit d684acc into main Dec 11, 2024
2 checks passed
@daavoo daavoo deleted the 31-add-docs-template-to-blueprint-template branch December 11, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs template to Blueprint Template
2 participants